billing
-
@Devboxes can you take
ENG-215,
ENG-216 and
ENG-217 tonight? small billing tickets from Lisa, one change per ticket please
-
Looked at 4 sources
-
Read ENG-215, ENG-216 and ENG-217
-
Ran the tests in each workspace
-
Read the checks on #48 to #50
-
Linked each change to its ticket
All three are up.
#48 greets the company when there's no contact name,
#49 pads new invoice numbers to five digits and leaves sent invoices alone, and
#50 makes customer search ignore case.
GitHub
#48 Greet the company when there's no contact name
Open
devboxes/eng-2153 checks passedGitHub
#49 Pad new invoice numbers to five digits
Open
devboxes/eng-2163 checks passedGitHub
#50 Ignore case in customer search
Open
devboxes/eng-2173 checks passed3 ready for review
-
Greet the company when there's no contact name #48
devboxes Bot reviewed 2 minutes ago View reviewed changes
All checks have passed
3 successful checks
- CI / Lint (pull_request) Details
- CI / Typecheck (pull_request) Details
- CI / Tests (pull_request) Details
This branch has no conflicts with the base branch
Merging can be performed automatically.
You can also merge this with the command line.
Files changed 1
-
src/reminders/greeting.ts+12 −3
Pad new invoice numbers to five digits #49
devboxes Bot reviewed 2 minutes ago View reviewed changes
devboxes Bot left a comment
Fixed one thing: the padding also renamed the PDFs of invoices already sent. It now runs only when a new number is issued.
All checks have passed
3 successful checks
- CI / Lint (pull_request) Details
- CI / Typecheck (pull_request) Details
- CI / Tests (pull_request) Details
This branch has no conflicts with the base branch
Merging can be performed automatically.
You can also merge this with the command line.
Files changed 1
-
src/invoices/numbering.ts+22 −6
Ignore case in customer search #50
devboxes Bot reviewed 2 minutes ago View reviewed changes
devboxes Bot left a comment
Search finds "Müller" when you type "müller" and still uses the index on customer names.
All checks have passed
3 successful checks
- CI / Lint (pull_request) Details
- CI / Typecheck (pull_request) Details
- CI / Tests (pull_request) Details
This branch has no conflicts with the base branch
Merging can be performed automatically.
You can also merge this with the command line.
Files changed 1
-
src/customers/search.ts+9 −4
devboxes Bot left a comment Author
Customers with a contact name still get greeted by name. The company greeting applies only when the name is empty.