Ship a small feature from a Jira ticket

Devboxes builds a small feature from a Jira ticket and updates the same change when the reviewer asks for more.

  • Support
  • Product
  • Engineering
Search Acme

support

2

  1. Fabian

    @Devboxes can you pick up DEV-31? enterprise customers get payment reminders before their grace period is over

  2. Devboxes APP

    Looked at 4 sources
    1. Jira Read DEV-31 and its comments
    2. GitHub Opened src/dunning/schedule.ts
    3. GitHub Found gracePeriodDays on customers
    4. Jira Moved DEV-31 to In Review

    #52 is up. The first reminder now waits out the customer's grace period, which was already on the customer record. Checks pass and DEV-31 is in review.

    Jira

    DEV-31 Payment reminders ignore the enterprise grace period

    In Review Dunning

    GitHub

    #52 Respect the contract's grace period before reminding

    Open devboxes/dev-31 3 checks passed

    Ready for review

  3. Fabian

    @Devboxes Nina wants the grace period on #52 in business days, that's how the contracts are written

  4. Devboxes APP

    Looked at 3 sources
    1. GitHub Read Nina's comment on #52
    2. GitHub Found the reminders' calendar
    3. Terminal Ran the tests in its workspace

    Done. #52 now counts business days with the same calendar the reminders use, and there's a test for a due date right before a weekend.

    Updated

Payment reminders ignore the enterprise grace period

Description

Filed by Jonas. Enterprise contracts grant a grace period, but the first reminder goes out one day after the due date.

Activity

  1. Devboxes linked #52

  2. Devboxes moved the ticket to In Review

acme / ledger

Respect the contract's grace period before reminding #52

Open

devboxes[bot] wants to merge 1 commit into main from devboxes/dev-31

devboxes Bot reviewed 2 minutes ago View reviewed changes

devboxes Bot left a comment Author

Business days come from the calendar the reminders already use, so public holidays count the same way in both.

All checks have passed

3 successful checks

  • CI / Lint (pull_request) Details
  • CI / Typecheck (pull_request) Details
  • CI / Tests (pull_request) Details

This branch has no conflicts with the base branch

Merging can be performed automatically.

You can also merge this with the command line.

Files changed 2

  • src/dunning/schedule.ts +16 −4
  • test/dunning-grace-period.test.ts +38 −0