hand this to devboxes: remove legacyFormatCurrency and move its callers to formatMoney
Devboxes finished it in #53 with your team's "Remove a deprecated helper" Blueprint. All callers use formatMoney now, including one in a script that the review caught. Checks pass.
Remove legacyFormatCurrency #53
devboxes Bot reviewed 2 minutes ago View reviewed changes
All checks have passed
3 successful checks
- CI / Lint (pull_request) Details
- CI / Typecheck (pull_request) Details
- CI / Tests (pull_request) Details
This branch has no conflicts with the base branch
Merging can be performed automatically.
You can also merge this with the command line.
Files changed 5
-
src/invoices/invoice-text.ts+6 −6 -
src/dunning/reminder-email.ts+4 −4 -
src/payouts/statement.ts+5 −5 -
scripts/backfill-invoices.ts+2 −2 -
src/money/legacy.ts+0 −31
devboxes Bot left a comment
scripts/backfill-invoices.ts still called legacyFormatCurrency. Moved it to formatMoney in a second commit, and nothing else uses the old helper.