Fix a check that fails only in CI

Send Devboxes a failing check and get the fix back on the same change, with the cause in a sentence.

  • Engineering
Search Acme

billing

2

  1. Lena

    @Devboxes CI fails on #45 but everything passes locally, can you fix it?

  2. Devboxes APP

    Looked at 5 sources
    1. GitHub Read the failing test log on #45
    2. GitHub Opened src/payouts/csv-export.ts
    3. GitHub Committed the isoDate fix to #45
    4. Terminal Ran the tests in UTC and Berlin time
    5. GitHub Read the checks on #45

    Fixed, #45 is green. The export formatted payout dates with toLocaleDateString, and CI runs in UTC, so a payout at 00:30 Berlin time landed on the day before. I added a commit on top of yours that switches to isoDate.

    GitHub

    #45 Export payouts as CSV

    Open lena/payout-csv-export 3 checks passed

    Checks green

acme / ledger

Export payouts as CSV #45

Open

lena wants to merge 2 commits into main from lena/payout-csv-export

devboxes Bot reviewed 2 minutes ago View reviewed changes

devboxes Bot left a comment

Payout dates now match in UTC and Berlin time. CSV columns are unchanged.

All checks have passed

3 successful checks

  • CI / test (pull_request) Details
  • CI / typecheck (pull_request) Details
  • CI / coverage (pull_request) Details

This branch has no conflicts with the base branch

Merging can be performed automatically.

You can also merge this with the command line.

Files changed 1

  • src/payouts/csv-export.ts +3 −2