Review a teammate's change before it ships

Devboxes checks a change for the cases its tests miss and shows you an example of each.

  • Engineering
  • Leadership
Search Acme

billing

2

  1. Anna

    @Devboxes Fabian's out today and I'd like to merge his customer import PR #46. can you give it a second look first?

  2. Devboxes APP

    Looked at 3 sources
    1. GitHub Read the changes in #46
    2. GitHub Read its tests, all with commas
    3. Terminal Imported a file saved by Excel

    Two problems the tests miss, both with files saved by German Excel: semicolons put every customer in one column, and a byte order mark drops the first column's name.

    Devboxes

    Review of #46

    Finding: A file saved by German Excel uses semicolons, so every customer lands in one column.

    Review posted

Report posted by Devboxes

Review of #46

  • Finding A file saved by German Excel uses semicolons, so every customer lands in one column.
  • Finding A file that starts with a byte order mark loses the name of its first column.
  • Suggest Read the separator from the header line, strip the byte order mark, and add both files to the tests.