What you ask
Search Acme
support
2
-
@devboxes can you pick up
DEV-31? enterprise customers get payment reminders before their grace period is over
-
Looked at 4 sources
-
Read DEV-31 and its comments
-
Opened src/dunning/schedule.ts
-
Found gracePeriodDays on customers
-
Moved DEV-31 to In Review
#52 is up. The first reminder now waits out the customer's grace period, which was already on the customer record. Checks pass and
DEV-31 is in review.
Opened #52
-
-
@devboxes Nina wants the grace period on
#52 in business days, that's how the contracts are written
-
Looked at 3 sources
-
Read Nina's comment on #52
-
Found the reminders' calendar
-
Ran the tests
Done.
#52 now counts business days with the same calendar the reminders use, and there's a test for a due date right before a weekend.
Updated #52
-
What devboxes does
-
Read the issue
- The issue is restated as checkable acceptance criteria.
-
Find the code
- The files to change and their tests are identified.
-
Make the change
- Every acceptance criterion is met.
- Tests cover the change.
-
-
Install dependencies
-
Test
-
Lint
-
-
Fix
- The tests pass.
-
Test again
-
Lint again
-
-
-
Publish
-
Review
What you get back
Payment reminders ignore the enterprise grace periodFiled by Jonas. Enterprise contracts grant a grace period, but the first reminder goes out one day after the due date.
Respect the contract's grace period before remindingBusiness days come from the calendar the reminders already use, so public holidays count the same way in both.
Good for
Startups